sequence: Remove deprecated options which are no longer used#1335
Merged
danpovey merged 1 commit intokaldi-asr:masterfrom Jan 12, 2017
Merged
sequence: Remove deprecated options which are no longer used#1335danpovey merged 1 commit intokaldi-asr:masterfrom
danpovey merged 1 commit intokaldi-asr:masterfrom
Conversation
Contributor
|
Did you make sure they are not used in any scripts?
…On Thu, Jan 12, 2017 at 10:33 AM, Vimal Manohar ***@***.***> wrote:
Remove deprecated functions used in nnet3-modify-learning-rates binary,
such as ScaleLearningRate and SetLearningRates. These could be added to
nnet edits-config if needed.
------------------------------
You can view, comment on, or merge this pull request online at:
#1335
Commit Summary
- sequence: Remove deprecated options which are no longer used
File Changes
- *M* src/nnet3/nnet-utils.cc
<https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-0> (73)
- *M* src/nnet3/nnet-utils.h
<https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-1> (22)
- *M* src/nnet3bin/nnet3-am-copy.cc
<https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-2> (8)
Patch Links:
- https://github.com/kaldi-asr/kaldi/pull/1335.patch
- https://github.com/kaldi-asr/kaldi/pull/1335.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1335>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADJVu6ytSXpEPE_pLpuvMkNV-GtTDu-Bks5rRnIGgaJpZM4LiFfm>
.
|
Contributor
Author
|
It was used only in nnet3-modify-learning-rates, which is removed. I didn't
find any scripts when I searched these options in github.
Vimal
On Thu, Jan 12, 2017 at 3:32 PM Daniel Povey <notifications@github.com>
wrote:
Did you make sure they are not used in any scripts?
On Thu, Jan 12, 2017 at 10:33 AM, Vimal Manohar ***@***.***> wrote:
Remove deprecated functions used in nnet3-modify-learning-rates binary,
such as ScaleLearningRate and SetLearningRates. These could be added to
nnet edits-config if needed.
------------------------------
You can view, comment on, or merge this pull request online at:
#1335
Commit Summary
- sequence: Remove deprecated options which are no longer used
File Changes
- *M* src/nnet3/nnet-utils.cc
<https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-0> (73)
- *M* src/nnet3/nnet-utils.h
<https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-1> (22)
- *M* src/nnet3bin/nnet3-am-copy.cc
<https://github.com/kaldi-asr/kaldi/pull/1335/files#diff-2> (8)
Patch Links:
- https://github.com/kaldi-asr/kaldi/pull/1335.patch
- https://github.com/kaldi-asr/kaldi/pull/1335.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1335>, or mute the thread
<
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1335 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEATV8TPgIhmsvL6crzzRrIgPU1nr8oeks5rRo3NgaJpZM4LiFfm>
.
…--
Vimal Manohar
PhD Student
Electrical & Computer Engineering
Johns Hopkins University
|
Contributor
|
OK, merging. We can add them back later if they're needed for something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated functions used in nnet3-modify-learning-rates binary, such as ScaleLearningRate and SetLearningRates. These could be added to nnet edits-config if needed.